Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] Fix TARGET_NVIDIA_GPU macro defines for sycl_ext_oneapi_device_architecture #15610

Closed
wants to merge 1 commit into from
Closed

[SYCL] Fix TARGET_NVIDIA_GPU macro defines for sycl_ext_oneapi_device_architecture #15610

wants to merge 1 commit into from

Conversation

GeorgeWeb
Copy link
Contributor

@GeorgeWeb GeorgeWeb commented Oct 4, 2024 •
edited
Loading

This PR fixes a typo in the sycl target arch macros for Nvidia by renaming __SYCL_TARGET_NVIDIA_GPU_SM to __SYCL_TARGET_NVIDIA_GPU_SM_. Resolves issue #15545.

@GeorgeWeb
Copy link
Contributor Author

GeorgeWeb commented Oct 4, 2024 •
edited
Loading

There are already existing (positive) Driver tests for these macros in clang/test/Driver/sycl-oneapi-gpu-nvidia.cpp that we pass the correct __SYCL_TARGET_NVIDIA_GPU_<SM_VERSION>__ define to the clang -cc1 invocation.

@GeorgeWeb GeorgeWeb marked this pull request as ready for review October 6, 2024 15:29
@GeorgeWeb GeorgeWeb requested a review from a team as a code owner October 6, 2024 15:29
@GeorgeWeb
Copy link
Contributor Author

Closing as duplicate of #15615

@GeorgeWeb GeorgeWeb closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bso-intel bso-intel Awaiting requested review from bso-intel bso-intel is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@GeorgeWeb